From 6a6369ae9eccd93efe229dd11ee3d45bbb745a48 Mon Sep 17 00:00:00 2001
From: lightheel <adrik.lightheel@gmail.com>
Date: Fri, 8 Aug 2025 12:17:47 -0400
Subject: [PATCH] Adjusted attack hit sprite location in landscape view.

---
 .../vbhelper/battle/HitEffectComposables.kt   | 19 +++++++++++++++++--
 .../vbhelper/screens/BattlesScreen.kt         |  2 +-
 2 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/com/github/nacabaro/vbhelper/battle/HitEffectComposables.kt b/app/src/main/java/com/github/nacabaro/vbhelper/battle/HitEffectComposables.kt
index 5110d1c..1f3210e 100644
--- a/app/src/main/java/com/github/nacabaro/vbhelper/battle/HitEffectComposables.kt
+++ b/app/src/main/java/com/github/nacabaro/vbhelper/battle/HitEffectComposables.kt
@@ -11,6 +11,7 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.asImageBitmap
 import androidx.compose.ui.layout.ContentScale
 import androidx.compose.ui.platform.LocalContext
+import androidx.compose.ui.platform.LocalConfiguration
 import androidx.compose.ui.unit.dp
 import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
@@ -25,6 +26,8 @@ fun HitEffectOverlay(
     if (!isVisible) return
     
     val context = LocalContext.current
+    val configuration = LocalConfiguration.current
+    val isLandscapeMode = configuration.orientation == android.content.res.Configuration.ORIENTATION_LANDSCAPE
     val hitEffectManager = remember { HitEffectSpriteManager(context) }
     val coroutineScope = rememberCoroutineScope()
     
@@ -92,10 +95,22 @@ fun HitEffectOverlay(
                     .offset(
                         x = if (isPlayerScreen) {
                             // On player screen, position further to the left
-                            (-sprite.width * scale / 2 - 100).dp
+                            if (isLandscapeMode) {
+                                // In landscape mode, move even further left for player screen
+                                (-sprite.width * scale / 2 - 300).dp
+                            } else {
+                                // In portrait mode, use original positioning
+                                (-sprite.width * scale / 2 - 100).dp
+                            }
                         } else {
                             // On enemy screen, position further to the right
-                            (-sprite.width * scale / 2 + 150).dp
+                            if (isLandscapeMode) {
+                                // In landscape mode, move even further right for enemy screen
+                                (-sprite.width * scale / 2 + 350).dp
+                            } else {
+                                // In portrait mode, use original positioning
+                                (-sprite.width * scale / 2 + 150).dp
+                            }
                         },
                         y = (-sprite.height * scale / 2 + 40).dp  // Position lower on screen (was -60, now +40)
                     ),
diff --git a/app/src/main/java/com/github/nacabaro/vbhelper/screens/BattlesScreen.kt b/app/src/main/java/com/github/nacabaro/vbhelper/screens/BattlesScreen.kt
index d2c2c1c..373b8eb 100644
--- a/app/src/main/java/com/github/nacabaro/vbhelper/screens/BattlesScreen.kt
+++ b/app/src/main/java/com/github/nacabaro/vbhelper/screens/BattlesScreen.kt
@@ -1941,7 +1941,6 @@ fun BattlesScreen() {
                             ) {
                                 Text("Sprite Animation Tester")
                             }
-                            */
                             Button(
                                 onClick = {
                                     val spriteFileManager = SpriteFileManager(context)
@@ -1951,6 +1950,7 @@ fun BattlesScreen() {
                             ) {
                                 Text("Clear Sprite Files")
                             }
+                             */
                         }
                     }
                 }